test: update custom domain integration tests#3868
Merged
valerena merged 3 commits intoaws:developfrom Jan 7, 2026
Merged
Conversation
The tests were outdated, so we got domains and hosted zones updated, so we need to update the values expected by the tests.
Contributor
|
Looks like a linting error is causing the tests to fail |
vicheey
reviewed
Jan 5, 2026
Contributor
Author
fixed! |
roger-zhangg
approved these changes
Jan 5, 2026
vicheey
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were outdated, so we updated domains and hosted zones, so we need to update the expected values here.
Issue #, if available
Integration tests were failing.
Description of changes
Updated the hosted zone and domain name for the tests, so the value of generated hashes for ApiGW Domain (depends on the domain name) and RecordSetGroup (depends on the hosted zone id) had to be updated.
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.